Skip to content

feat(stovepipe): persist request log records - #648

Open
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-request-history-storagefrom
mnoah1/stovepipe-request-history-persistence
Open

feat(stovepipe): persist request log records#648
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-request-history-storagefrom
mnoah1/stovepipe-request-history-persistence

Conversation

@mnoah1

@mnoah1 mnoah1 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Make the request-log schema usable through a backend-neutral, queue-scoped persistence contract.
  • Supply the retained records that the public request-history API projects as HistoryEvent values.

Changes:

  • Define validated RequestLog records with bounded state, event, and outcome-reason vocabularies plus opaque metadata.
  • Add create, point-read, and complete per-request list operations with no pagination.
  • Round-trip metadata through MySQL JSON without interpreting its keys or values, writing nil as {} and normalizing stored JSON null to an empty map.
  • Keep the raw metadata map out of the public protobuf; key-specific enforcement is deferred.
  • Implement and wire the MySQL store, generated mocks, and reusable backend contract tests.

Test Plan

  • Exercised metadata round trips, nil normalization, invalid JSON value handling, duplicate detection, point reads, queue isolation, and chronological listing.
  • ./tool/bazel test //api/stovepipe/... //service/stovepipe/... //stovepipe/...
  • make lint check-tidy check-gazelle

Revert Plan

Revert this PR; the table introduced by #645 remains unused.

Jira Issues

None.

@mnoah1
mnoah1 marked this pull request as ready for review August 28, 2026 18:19
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners August 28, 2026 18:19
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from f579429 to ccfd117 Compare August 31, 2026 16:28
@mnoah1 mnoah1 changed the title feat(stovepipe): persist request history entries feat(stovepipe): persist request log records Aug 31, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from ccfd117 to e9e663b Compare August 31, 2026 16:50
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from e9e663b to 7e55bb7 Compare August 31, 2026 17:19
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from 7e55bb7 to bd03f5d Compare August 31, 2026 17:33
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from bd03f5d to f733374 Compare August 31, 2026 22:21
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from f733374 to 50f14cc Compare August 31, 2026 22:38
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from 50f14cc to 14c02f4 Compare August 31, 2026 22:52
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-persistence branch from 14c02f4 to 3f3c79e Compare August 31, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant